You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…3364)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
## Current Behavior
<!-- This is the behavior we have today -->
The migration to update vite config is incorrectly matching other object
literal and arrow functions
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Ensure more accurate updating of vite config file
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes#20921
(cherry picked from commit 88297dd)
…3364)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
## Current Behavior
<!-- This is the behavior we have today -->
The migration to update vite config is incorrectly matching other object
literal and arrow functions
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Ensure more accurate updating of vite config file
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes#20921
EDIT: Potentially resolved by this? #20693 I did not try it to confirm.
Current Behavior
update-vite-config migration updated my custom plugin instead of the actual vite configuration.
In addition, worker plugins should have been updated to a function instead of an array as part of migration for this vite breaking change
Expected Behavior
The vite configuration should have correctly identified the configuration, and not other non-configuration data within the file.
GitHub Repo
https://github.com/jetstreamapp/jetstream/tree/v3.7.0
Steps to Reproduce
npx nx migrate latest
update-17-2-7
from the migration file to workaround Migration "update-17-2-7" fails if a project does not have .eslintrc.json #20920 since that issue is irrelevant here.npx nx migrate --run-migrations
vite.config.ts
Nx Report
Failure Logs
No response
Package Manager Version
yarn 1.22.19
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: