-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): migration should handle config object correctly #20921 #23364
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8cce248. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
6ae3299
to
8cce248
Compare
…3364) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> The migration to update vite config is incorrectly matching other object literal and arrow functions ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Ensure more accurate updating of vite config file ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #20921 (cherry picked from commit 88297dd)
…3364) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> The migration to update vite config is incorrectly matching other object literal and arrow functions ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Ensure more accurate updating of vite config file ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #20921
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The migration to update vite config is incorrectly matching other object literal and arrow functions
Expected Behavior
Ensure more accurate updating of vite config file
Related Issue(s)
Fixes #20921