Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx report results in "Failed to process project graph. Run "nx reset" to fix this" #23296

Closed
1 of 4 tasks
beeman opened this issue May 10, 2024 · 5 comments · Fixed by #23368
Closed
1 of 4 tasks

nx report results in "Failed to process project graph. Run "nx reset" to fix this" #23296

beeman opened this issue May 10, 2024 · 5 comments · Fixed by #23368
Assignees

Comments

@beeman
Copy link
Contributor

beeman commented May 10, 2024

Current Behavior

When running pnpm nx report in this project I get this error:

 NX   Failed to process project graph. Run "nx reset" to fix this. Please report the issue if you keep seeing it.

Running nx reset does not fix this. Error occurred when recreating #23295

Expected Behavior

pnpm nx report should work.

GitHub Repo

https://github.com/beeman/solana-dapp-react-version

Steps to Reproduce

  1. git clone https://github.com/beeman/solana-dapp-react-version
  2. cd solana-dapp-react-version
  3. pnpm install
  4. pnpm nx report
  5. Observe error
  6. pnpm nx reset
  7. Observe nothing changes

Nx Report

😁

Failure Logs

❯ pnpm nx report

 NX   Failed to process project graph. Run "nx reset" to fix this. Please report the issue if you keep seeing it.

Pass --verbose to see the stacktraces.

❯ pnpm nx reset

 NX   Resetting the Nx workspace cache and stopping the Nx Daemon.

This might take a few minutes.


 NX   Daemon Server - Stopped


 NX   Successfully reset the Nx workspace.

❯ pnpm nx report

 NX   Failed to process project graph. Run "nx reset" to fix this. Please report the issue if you keep seeing it.

Pass --verbose to see the stacktraces.

Package Manager Version

9.0.5

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

I've been having similar issues for quite some time now, but could never reproduce it consistently. With this project it seems to happen consistently.

@Coly010
Copy link
Contributor

Coly010 commented May 10, 2024

Let me take a closer look at what is causing the plugin graph to fail during creation and I'll update here again

@Coly010
Copy link
Contributor

Coly010 commented May 10, 2024

Hey @beeman !

So it's a true error, it's just a little bit hidden unfortunately.

The error comes from the web/webpack.config.js file.

It's trying to set fallback on config.resolve when resolve is undefined

console.log("config.resolve", config.resolve);
  config.resolve.fallback = {
    crypto: require.resolve('crypto-browserify'),
    stream: require.resolve('stream-browserify'),
  };

output:

config.resolve undefined

Changing that section to:

config.resolve ??= {};
  config.resolve.fallback = {
    crypto: require.resolve('crypto-browserify'),
    stream: require.resolve('stream-browserify'),
  };

Allows it to work:

 NX   Report complete - copy this into the issue template

Node   : 20.12.2
OS     : darwin-arm64
pnpm   : 8.15.7

nx                 : 19.0.0
@nx/js             : 19.0.0
@nx/jest           : 19.0.0
@nx/linter         : 19.0.0
@nx/eslint         : 19.0.0
@nx/workspace      : 19.0.0
@nx/devkit         : 19.0.0
@nx/eslint-plugin  : 19.0.0
@nx/react          : 19.0.0
@nx/rollup         : 19.0.0
@nrwl/tao          : 19.0.0
@nx/web            : 19.0.0
@nx/webpack        : 19.0.0
typescript         : 5.4.5
---------------------------------------
Registered Plugins:
@nx/webpack/plugin
@nx/eslint/plugin
---------------------------------------
Community plugins:
@solana-developers/preset-react : 3.0.0-beta.4

To uncover errors like these, you can run NX_DAEMON=false pnpm nx graph
Or you can check in the .nx/cache/d/daemon.log

@Coly010 Coly010 closed this as completed May 10, 2024
@abelabbesnabi
Copy link

abelabbesnabi commented May 10, 2024

It also happens after installing a second app.

After I do a successful: "nx g @nx/react:app website" all is fine

But then when I try to add another app: "nx g @nx/express:app api" then I see this error:

"NX Failed to process project graph. Run "nx reset" to fix this. Please report the issue if you keep seeing it."

This is a blocker and should be treated as urgent. It's impossible to use NX at this point to create a functional application.

@beeman
Copy link
Contributor Author

beeman commented May 10, 2024

Hey @beeman !

So it's a true error, it's just a little bit hidden unfortunately.

The error comes from the web/webpack.config.js file.

It's trying to set fallback on config.resolve when resolve is undefined

console.log("config.resolve", config.resolve);
  config.resolve.fallback = {
    crypto: require.resolve('crypto-browserify'),
    stream: require.resolve('stream-browserify'),
  };

output:

config.resolve undefined

Changing that section to:

config.resolve ??= {};
  config.resolve.fallback = {
    crypto: require.resolve('crypto-browserify'),
    stream: require.resolve('stream-browserify'),
  };

Thanks for checking this @Coly010 .

I don't think this should be closed, as it's a regression.

The same webpack.config.js worked fine in previous versions. For example in this repo there is the exact same file, and pnpm nx report works as expected.

The previous and expected behavior is that these webpack options are merged. With that in mind, it only makes sense that it would create any missing parent keys.

To uncover errors like these, you can run NX_DAEMON=false pnpm nx graph Or you can check in the .nx/cache/d/daemon.log

This is very useful, thanks. I've been getting these errors all the time lately and never knew how to debug it!

@Coly010
Copy link
Contributor

Coly010 commented May 14, 2024

Hi @beeman :)

The repo you linked in the latest comment doesn't using Inference Plugins, therefore the webpack.config.js files are not being resolved.

If you set the webpack plugin in the pubkey repo, and run nx reset and then nx report, you'll see it also fails.

Therefore, I would not say this is a regression.

When resolving the webpack config, which in this case returns a function which takes a config object and transforms it, we pass an empty object as the starting point for the config, which is then built up over time.

There are some config options that are only set during the actual build when using withNx. Perhaps we can initialize some more with empty objects.

@Coly010 Coly010 reopened this May 14, 2024
Coly010 added a commit that referenced this issue May 14, 2024
…23296 (#23368)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
The `@nx/webpack/plugin` will resolve and read webpack options from user
defined config files.
However, it does not set the env vars indicating that a task is being
run, because tasks are not being run at this stage.

This means that certain config properties are not being set by
`applyBaseConfig`.

Users' webpack configs may rely on these properties being set so they
can modify them.
When not set, this throws, meaning the graph cannot be constructed.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Initialize the properties that we usually set when `applyBaseConfig` is
used.


## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #23296
FrozenPandaz pushed a commit that referenced this issue May 14, 2024
…23296 (#23368)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
The `@nx/webpack/plugin` will resolve and read webpack options from user
defined config files.
However, it does not set the env vars indicating that a task is being
run, because tasks are not being run at this stage.

This means that certain config properties are not being set by
`applyBaseConfig`.

Users' webpack configs may rely on these properties being set so they
can modify them.
When not set, this throws, meaning the graph cannot be constructed.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Initialize the properties that we usually set when `applyBaseConfig` is
used.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #23296

(cherry picked from commit 3e84967)
Coly010 added a commit that referenced this issue May 15, 2024
…23296 (#23368)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
The `@nx/webpack/plugin` will resolve and read webpack options from user
defined config files.
However, it does not set the env vars indicating that a task is being
run, because tasks are not being run at this stage.

This means that certain config properties are not being set by
`applyBaseConfig`.

Users' webpack configs may rely on these properties being set so they
can modify them.
When not set, this throws, meaning the graph cannot be constructed.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Initialize the properties that we usually set when `applyBaseConfig` is
used.


## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #23296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants