fix(webpack): apply-base-config should initialize options it will set #23296 #23368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4d13625. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
approved these changes
May 14, 2024
|
Thank you @Coly010! 🙌 |
FrozenPandaz
pushed a commit
that referenced
this pull request
May 14, 2024
…23296 (#23368) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> The `@nx/webpack/plugin` will resolve and read webpack options from user defined config files. However, it does not set the env vars indicating that a task is being run, because tasks are not being run at this stage. This means that certain config properties are not being set by `applyBaseConfig`. Users' webpack configs may rely on these properties being set so they can modify them. When not set, this throws, meaning the graph cannot be constructed. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Initialize the properties that we usually set when `applyBaseConfig` is used. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23296 (cherry picked from commit 3e84967)
Coly010
added a commit
that referenced
this pull request
May 15, 2024
…23296 (#23368) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> The `@nx/webpack/plugin` will resolve and read webpack options from user defined config files. However, it does not set the env vars indicating that a task is being run, because tasks are not being run at this stage. This means that certain config properties are not being set by `applyBaseConfig`. Users' webpack configs may rely on these properties being set so they can modify them. When not set, this throws, meaning the graph cannot be constructed. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Initialize the properties that we usually set when `applyBaseConfig` is used. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23296
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/webpack/pluginwill resolve and read webpack options from user defined config files.However, it does not set the env vars indicating that a task is being run, because tasks are not being run at this stage.
This means that certain config properties are not being set by
applyBaseConfig.Users' webpack configs may rely on these properties being set so they can modify them.
When not set, this throws, meaning the graph cannot be constructed.
Expected Behavior
Initialize the properties that we usually set when
applyBaseConfigis used.Related Issue(s)
Fixes #23296