Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): file-server withDeps is deprecated #9170

Merged
merged 2 commits into from Mar 9, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Mar 3, 2022

Current Behavior

withDeps is deprecated however it is being set to true by default.

Expected Behavior

withDeps should not be set to true and correct replacement should be defined

@Coly010 Coly010 self-assigned this Mar 3, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 3, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 3494e2f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/3N9q6bSEsfZXt9TXtg93ANZgoodx
✅ Preview: https://nx-dev-git-fork-coly010-fix-file-server-with-deps-nrwl.vercel.app

@FrozenPandaz FrozenPandaz merged commit 1440f83 into nrwl:master Mar 9, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants