Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(angular): update angular cli migration docs to reflect the generator relocation to @nrwl/angular #9288

Merged
merged 3 commits into from Mar 18, 2022

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 11, 2022

Updates the Angular CLI migration docs to reflect that the @nrwl/workspace:ng-add generator is being moved to the @nrwl/angular package.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 11, 2022
@vercel
Copy link

vercel bot commented Mar 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/D5RAKQ3VQDfiDyGKDYAmZcH12Aei
✅ Preview: https://nx-dev-git-fork-leosvelperez-angular-move-ng-add-docs-nrwl.vercel.app

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

docs/shared/migration/migration-angular.md Outdated Show resolved Hide resolved
docs/shared/migration/migration-angular.md Outdated Show resolved Hide resolved
@FrozenPandaz FrozenPandaz marked this pull request as ready for review March 18, 2022 21:22
@FrozenPandaz FrozenPandaz merged commit 0a88ba4 into nrwl:master Mar 18, 2022
FrozenPandaz added a commit that referenced this pull request Mar 18, 2022
…he generator relocation to @nrwl/angular (#9288)"

This reverts commit 0a88ba4.
FrozenPandaz added a commit that referenced this pull request Mar 18, 2022
…he generator relocation to @nrwl/angular (#9288)" (#9400)

This reverts commit 0a88ba4.
FrozenPandaz added a commit that referenced this pull request Mar 18, 2022
…ator relocation to @nrwl/angular (#9288)

* docs(angular): update angular cli migration docs to reflect the generator relocation to @nrwl/angular

* chore: add @

* chore: add @

Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
FrozenPandaz added a commit that referenced this pull request Mar 18, 2022
…ator relocation to @nrwl/angular (#9288)

* docs(angular): update angular cli migration docs to reflect the generator relocation to @nrwl/angular

* chore: add @

* chore: add @

Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
FrozenPandaz added a commit that referenced this pull request Mar 18, 2022
…ator relocation to @nrwl/angular (#9288) (#9401)

* docs(angular): update angular cli migration docs to reflect the generator relocation to @nrwl/angular

Co-authored-by: Jason Jean <jasonjean1993@gmail.com>

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
@leosvelperez leosvelperez deleted the angular/move-ng-add-docs branch March 21, 2022 12:20
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants