cleanup(angular): move the angular cli migration generator from @nrwl/workspace to @nrwl/angular #9244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/8jWZkQ9UCeFzGjUvhsK2XWGTJkJv [Deployment for f5e2978 canceled] |
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
7415c2e
to
7ef21b1
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
7ef21b1
to
da05d9b
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
da05d9b
to
8e39f2d
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
8e39f2d
to
f88dc44
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
f88dc44
to
7611318
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
7611318
to
7fac228
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
7fac228
to
513b87e
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
513b87e
to
1daa17d
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
1daa17d
to
968f203
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
968f203
to
42a4cf5
Compare
leosvelperez
force-pushed
the
angular/move-ng-add
branch
from
42a4cf5
to
f5e2978
Compare
FrozenPandaz
approved these changes
Mar 18, 2022
...ges/angular/src/generators/ng-add/files/decorate-angular-cli/decorate-angular-cli.js__tmpl__
Show resolved
Hide resolved
|
It looks good but there's a lot more to clean up. @leosvelperez Please take a look at them. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the existing generator
@nrwl/workspace:ng-addto the@nrwl/angularpackage. This generator is only used for migrating Angular CLI workspaces to Nx. Themake-angular-cli-fasterpackage is also updated to handle the change.The docs for the migration also need to be updated after this change is released. This is done in #9288.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #