Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): targets referred to by targetDependencies should be optional by default #9344

Merged
merged 1 commit into from Mar 18, 2022

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Mar 15, 2022

Current Behavior

Adding a targetDependency such as below requires that all projects have build-base available

{
  "build": [{
     "target": "build-base",
     "projects": "dependencies"
  }]
}

Expected Behavior

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Mar 15, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit c15375d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/AAqTTCo854FLFV3bkRRoFd8NWsKC
✅ Preview: Canceled

[Deployment for c15375d canceled]

packages/nx/src/shared/workspace.ts Outdated Show resolved Hide resolved
@AgentEnder AgentEnder force-pushed the fix/target-dependencies-should-be-optional branch from d97486f to a6983ad Compare March 15, 2022 22:10
@AgentEnder AgentEnder force-pushed the fix/target-dependencies-should-be-optional branch from a6983ad to c15375d Compare March 17, 2022 20:30
@FrozenPandaz FrozenPandaz merged commit 05f72c9 into master Mar 18, 2022
@FrozenPandaz FrozenPandaz deleted the fix/target-dependencies-should-be-optional branch March 18, 2022 19:30
FrozenPandaz pushed a commit that referenced this pull request Mar 21, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants