fix(core): Skip dependencies already added (avoid circular dependencies)

[danielsharvey]

The project utility method collectDependentProjectNodesNames() produces a stack overflow (e.g. producing project dependencies for tailwind.config.js when circular dependencies exist.

Fix by adding loop detection for "already added" dependencies.

Current Behavior

Currently, when a circular dependency exists, operations like (for example) a development build for an Angular app including Tailwind produces a stack overflow as follows:

⠇ Generating browser application bundles (phase: building)...Error: createGlobPatternsForDependencies: Error when generating globs.
Maximum call stack size exceeded
    at createGlobPatternsForDependencies (/<project-dir>/node_modules/@nrwl/workspace/src/utilities/generate-globs.js:31:15)
    at createGlobPatternsForDependencies (/<project-dir>/node_modules/@nrwl/angular/tailwind.js:12:71)
    at Object.<anonymous> (/<project-dir>/apps/sandbox/tailwind.config.js:72:8)
    at Module._compile (internal/modules/cjs/loader.js:1072:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1101:10)
    at Module.load (internal/modules/cjs/loader.js:937:32)
    at Function.Module._load (internal/modules/cjs/loader.js:778:12)
    at Module.require (internal/modules/cjs/loader.js:961:19)
    at Module.require (/<project-dir>/node_modules/nx/src/compat/compat.js:14:40)
    at require (internal/modules/cjs/helpers.js:92:18)
    at getTailwindConfig (/<project-dir>/node_modules/tailwindcss/lib/lib/setupTrackingContext.js:65:53)
    at /<project-dir>/node_modules/tailwindcss/lib/lib/setupTrackingContext.js:124:92
    at /<project-dir>/node_modules/tailwindcss/lib/processTailwindFeatures.js:43:11
    at plugins (/<project-dir>/node_modules/tailwindcss/lib/index.js:20:104)
    at LazyResult.runOnRoot (/<project-dir>/node_modules/@angular-devkit/build-angular/node_modules/postcss/lib/lazy-result.js:339:16)
    at LazyResult.runAsync (/<project-dir>/node_modules/@angular-devkit/build-angular/node_modules/postcss/lib/lazy-result.js:393:26)

[createGlobPatternsForDependencies] WARNING: There was no ProjectGraph available to read from, returning an empty array of glob patterns

Expected Behavior

Ideally, circular dependencies should be detected and recursion avoided.

Related Issue(s)

I've taken a similar approach to #2022.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f4b9faa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 13 targets

• nx affected --target=build --base=0bd08cccbaaeda3f5355f548625169b0006faa0b --head=f4b9faadd76232aeb4be7c4172fb86ed46f9d246 --parallel=3
• nx affected --target=e2e --base=0bd08cccbaaeda3f5355f548625169b0006faa0b --head=f4b9faadd76232aeb4be7c4172fb86ed46f9d246 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=0bd08cccbaaeda3f5355f548625169b0006faa0b --head=f4b9faadd76232aeb4be7c4172fb86ed46f9d246 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=0bd08cccbaaeda3f5355f548625169b0006faa0b --head=f4b9faadd76232aeb4be7c4172fb86ed46f9d246 --parallel=3
• nx affected --target=test --base=0bd08cccbaaeda3f5355f548625169b0006faa0b --head=f4b9faadd76232aeb4be7c4172fb86ed46f9d246 --parallel=1
• nx build typedoc-theme
• nx run-many --target=build --all --parallel=8 --exclude=docs,nx-dev-data-access-documents,nx-dev-e2e,nx-dev,nx-dev-feature-analytics,nx-dev-feature-conf,nx-dev-feature-doc-viewer,nx-dev-feature-search,nx-dev-feature-storage,nx-dev-feature-versions-and-flavors,nx-dev-ui-commands,nx-dev-ui-common,nx-dev-ui-home,nx-dev-ui-member-card,nx-dev-ui-sponsor...
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn documentation
• nx-cloud record -- yarn nx format:check --base=0bd08cccbaaeda3f5355f548625169b0006faa0b --head=f4b9faadd76232aeb4be7c4172fb86ed46f9d246
• nx-cloud record -- yarn nx workspace-lint

---

Sent with 💌 from NxCloud.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/9MxPYpyPxFkFrmwti8JkCfzpf11z
✅ Preview: Ignored

[Deployment for e3928c5 canceled]

[FrozenPandaz]

Thank you for your contribution! LGTM 🎉

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	Apr 29, 2022 at 6:51PM (UTC)

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.