Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Skip dependencies already added (avoid circular dependencies) #9744

Merged
merged 3 commits into from
May 4, 2022
Merged

fix(core): Skip dependencies already added (avoid circular dependencies) #9744

merged 3 commits into from
May 4, 2022

Commits on Apr 29, 2022

  1. fix(core): Skip dependencies already added (avoid circular) 

    The project utility method `collectDependentProjectNodesNames()`
produces a stack overflow (e.g. producing project dependencies for
`tailwind.config.js` when circular dependencies exist.

Fix by adding loop detection for "already add" dependencies.
    @danielsharvey @FrozenPandaz
    danielsharvey authored and FrozenPandaz committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    63ade53 View commit details
    Browse the repository at this point in the history

  2. cleanup(core): Correct formating

    @danielsharvey @FrozenPandaz
    danielsharvey authored and FrozenPandaz committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    419fdac View commit details
    Browse the repository at this point in the history

  3. chore(core): add test for circular dependencies in getSourceDirOfDepe… 

    …ndentProjects
    @FrozenPandaz
    FrozenPandaz committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    f4b9faa View commit details
    Browse the repository at this point in the history