fix(core): allow parsing dot notation cli args #9812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/GqStXasvSrXgpvPYEDUfpMGse8rF [Deployment for 5e216bd canceled] |
barbados-clemens
added
scope: testing tools
FrozenPandaz
requested changes
Apr 13, 2022
barbados-clemens
force-pushed
the
nx-dot-notation-parse
branch
from
1bd9c12
to
a88c434
Compare
parse dot notation cli args for env args passed to cypress executor to override cypress.env.json values. i.e. nx e2e project --env.API_URL=localhost:1234 will now correctly give cypress e2e args to override the cypress.env.json values ISSUES CLOSED: #9764
barbados-clemens
force-pushed
the
nx-dot-notation-parse
branch
from
a88c434
to
5e216bd
Compare
FrozenPandaz
approved these changes
Apr 14, 2022
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 19, 2022
parse dot notation cli args for env args passed to cypress executor to override cypress.env.json values. i.e. nx e2e project --env.API_URL=localhost:1234 will now correctly give cypress e2e args to override the cypress.env.json values ISSUES CLOSED: #9764
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse dot notation cli args for env args passed to cypress executor to override cypress.env.json
values.
i.e.
nx e2e project --env.API_URL=localhost:1234will now correctly give cypress e2e args to
override the cypress.env.json values
Current Behavior
nx e2e project --env.API_URL=localhost:1234does not parse the correct env args for cypressExpected Behavior
nx e2e project --env.API_URL=localhost:1234correctly is parsed for cypressRelated Issue(s)
Fixes #9764