fix(core): add dependency for cliui + string-width #9967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When
astro
is installed, Nx commands error as they are unable to importstring-width
?Expected Behavior
Nx brings its own version of
string-width
and isn't broken when installing other package?@JamesHenry I understand we wanted to transitively depend on these dependencies but I wonder if there's a way that
yargs
exposes itself that we can use to do this? 🤷Better to maintain the version ourselves than to throw errors.
Related Issue(s)
Fixes https://nrwlcommunity.slack.com/archives/CMFKWPU6Q/p1650660946152879