Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add dependency for cliui + string-width #9967

Merged
merged 1 commit into from
Apr 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,13 @@
"send": "0.17.1",
"tailwindcss": "^3.0.13",
"tslib": "^2.3.0",
"weak-napi": "^2.0.2"
"weak-napi": "^2.0.2",
"cliui": "^7.0.2",
"string-width": "^4.2.3"
},
"resolutions": {
"ng-packagr/rxjs": "6.6.7",
"**/xmlhttprequest-ssl": "~1.6.2",
"minimist": "^1.2.6"
}
}
}
2 changes: 2 additions & 0 deletions packages/nx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
"tmp": "~0.2.1",
"yargs": "^17.4.0",
"yargs-parser": "21.0.1",
"cliui": "^7.0.2",
"string-width": "^4.2.3",
"chalk": "4.1.0",
"flat": "^5.0.2",
"minimatch": "3.0.4",
Expand Down
7 changes: 0 additions & 7 deletions scripts/depcheck/missing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,6 @@ const IGNORE_MATCHES = {
'@angular-devkit/core',
'@angular-devkit/architect',
'@angular/cli',
/**
* cliui is the CLI layout engine developed by yargs and we want to use the version of it
* which our currently installed yargs version brings in. It in turn depends on a specific
* version of string-width which we also leverage directly in print-help.
*/
'cliui',
'string-width',
],
web: [
// we don't want to bloat the install of @nrwl/web by including @swc/core and swc-loader as a dependency.
Expand Down