Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular): expose builder functions #10252

Merged
merged 1 commit into from
May 16, 2022
Merged

feat(angular): expose builder functions #10252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/angular/executors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
export * from './src/builders/module-federation-dev-server/module-federation-dev-server.impl';
export * from './src/builders/webpack-browser/webpack-browser.impl';
export * from './src/builders/webpack-server/webpack-server.impl';
export * from './src/executors/delegate-build/delegate-build.impl';
export * from './src/executors/ng-packagr-lite/ng-packagr-lite.impl';
export * from './src/executors/package/package.impl';
10 changes: 6 additions & 4 deletions ...es/angular/src/builders/module-federation-dev-server/module-federation-dev-server.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import { scheduleTarget } from 'nx/src/adapter/ngcli-adapter';
import { BuilderContext, createBuilder } from '@angular-devkit/architect';
import { JsonObject } from '@angular-devkit/core';
import { join } from 'path';
import { webpackServer } from '../webpack-server/webpack-server.impl';
import { executeWebpackServerBuilder } from '../webpack-server/webpack-server.impl';

export function moduleFederationDevServer(
export function executeModuleFederationDevServerBuilder(
schema: Schema,
context: BuilderContext
) {
Expand Down Expand Up @@ -63,7 +63,9 @@ export function moduleFederationDevServer(
});
}

return webpackServer(options, context);
return executeWebpackServerBuilder(options, context);
}

export default createBuilder<JsonObject & Schema>(moduleFederationDevServer);
export default createBuilder<JsonObject & Schema>(
executeModuleFederationDevServerBuilder
);
6 changes: 4 additions & 2 deletions packages/angular/src/builders/webpack-browser/webpack-browser.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function buildAppWithCustomWebpackConfiguration(
});
}

function run(
export function executeWebpackBrowserBuilder(
options: BrowserBuilderSchema,
context: BuilderContext
): Observable<BuilderOutput> {
Expand Down Expand Up @@ -132,4 +132,6 @@ function run(
);
}

export default createBuilder<JsonObject & BrowserBuilderSchema>(run) as any;
export default createBuilder<JsonObject & BrowserBuilderSchema>(
executeWebpackBrowserBuilder
) as any;
9 changes: 7 additions & 2 deletions packages/angular/src/builders/webpack-server/webpack-server.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ import { resolveCustomWebpackConfig } from '../utilities/webpack';
import { normalizeOptions } from './lib';
import type { Schema } from './schema';

export function webpackServer(schema: Schema, context: BuilderContext) {
export function executeWebpackServerBuilder(
schema: Schema,
context: BuilderContext
) {
process.env.NX_TSCONFIG_PATH = joinPathFragments(
context.workspaceRoot,
'tsconfig.base.json'
Expand Down Expand Up @@ -86,4 +89,6 @@ export function webpackServer(schema: Schema, context: BuilderContext) {
);
}

export default createBuilder<JsonObject & Schema>(webpackServer) as any;
export default createBuilder<JsonObject & Schema>(
executeWebpackServerBuilder
) as any;