-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): format .lib.swcrc file with nx format #10254
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
// Prettier supports ".swcrc" as a file instead of an extension | ||
// So we add ".swcrc" as a supported extension manually | ||
// which allows it to be considered for calculating "patterns" | ||
.concat('.swcrc'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we setup the json parser for the files when we generate the swcrc config, but if someone didnt use a generator and had an swcrc file, what would happen? Is there any way for us to set the json parser here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. Should we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can set it at runtime here, I'd think that'd be nicer. Looking at this code vs. the formatFiles
utility function, we aren't programmatically calling prettier. We are just using the CLI + child_process. That may make it hard or not feasible in this case.
That said, we probably want these changes in the formatFiles
helper too, s.t. the files are formatted if a generator changes them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it with runtime now. A little ugly but it's better than modifying the prettier config on generation (and modifying approach only works for .prettierrc in JSON format)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
ISSUES CLOSED: #10240
Current Behavior
Running
nx format
does not format.lib.swcrc
Expected Behavior
Running
nx format
should format.lib.swcrc
filesThis is tricky (and it's my fault for using
.lib.swcrc
). Prettier recognizes.swcrc
as a File instead of as an Extension. In addition, adding**/.*.swcrc
alone isn't enough.Related Issue(s)
Fixes #10240