Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): update e2e test case to cover env variables exported from libraries #10532

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

ndcunningham
Copy link
Contributor

Add a test case for libraries which exports env vars

ISSUES CLOSED: #9633

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 1, 2022 at 2:57PM (UTC)

@ndcunningham ndcunningham requested a review from jaysoo May 31, 2022 15:14
@ndcunningham ndcunningham force-pushed the defect/add-e2e-lib-env-export branch 2 times, most recently from 03ee6dd to c206847 Compare June 1, 2022 14:42
@ndcunningham ndcunningham force-pushed the defect/add-e2e-lib-env-export branch from c206847 to 0be5297 Compare June 1, 2022 14:57
@jaysoo jaysoo merged commit 89d9d9a into nrwl:master Jun 1, 2022
@ndcunningham ndcunningham deleted the defect/add-e2e-lib-env-export branch June 1, 2022 18:39
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Libs imported into Next.js apps do not have access to process.env in the client bundle
2 participants