feat(react-native): upgrade metro to 0.71.0

docs/generated/packages/react-native.json

@@ -130,6 +130,11 @@
             "type": "string",
             "enum": ["detox", "none"],
             "default": "detox"
+          },
+          "install": {
+            "type": "boolean",
+            "description": "Runs `pod install` for native modules before building iOS app.",
+            "default": true
           }
         },
         "required": [],
@@ -474,6 +479,11 @@
             "type": "string",
             "enum": ["detox", "none"],
             "default": "detox"
+          },
+          "install": {
+            "type": "boolean",
+            "description": "Runs `pod install` for native modules before building iOS app.",
+            "default": true
           }
         },
         "required": ["name"],

e2e/react-native/src/react-native.test.ts

@@ -20,7 +20,9 @@ describe('react native', () => {
     const libName = uniq('lib');
     const componentName = uniq('component');
 
-    runCLI(`generate @nrwl/react-native:application ${appName}`);
+    runCLI(
+      `generate @nrwl/react-native:application ${appName} --install=false`
+    );
     runCLI(`generate @nrwl/react-native:library ${libName}`);
     runCLI(
       `generate @nrwl/react-native:component ${componentName} --project=${libName} --export`
@@ -59,7 +61,9 @@ describe('react native', () => {
 
   it('should create storybook with application', async () => {
     const appName = uniq('my-app');
-    runCLI(`generate @nrwl/react-native:application ${appName}`);
+    runCLI(
+      `generate @nrwl/react-native:application ${appName} --install=false`
+    );
     runCLI(
       `generate @nrwl/react-native:storybook-configuration ${appName} --generateStories --no-interactive`
     );
@@ -86,7 +90,9 @@ describe('react native', () => {
 
   it('sync npm dependencies for autolink', async () => {
     const appName = uniq('my-app');
-    runCLI(`generate @nrwl/react-native:application ${appName}`);
+    runCLI(
+      `generate @nrwl/react-native:application ${appName} --install=false`
+    );
     // Add npm package with native modules
     updateFile(join('package.json'), (content) => {
       const json = JSON.parse(content);

package.json

@@ -180,7 +180,7 @@
     "license-webpack-plugin": "^4.0.2",
     "loader-utils": "1.2.3",
     "memfs": "^3.0.1",
-    "metro-resolver": "^0.70.3",
+    "metro-resolver": "^0.71.0",
     "mime": "2.4.4",
     "mini-css-extract-plugin": "~2.4.7",
     "minimatch": "3.0.5",

packages/detox/migrations.json

@@ -125,6 +125,15 @@
           "alwaysAddToPackageJson": false
         }
       }
+    },
+    "14.2.1": {
+      "version": "14.2.1-beta.0",
+      "packages": {
+        "detox": {
+          "version": "19.7.1",
+          "alwaysAddToPackageJson": false
+        }
+      }
     }
   }
 }

packages/detox/package.json

@@ -32,7 +32,7 @@
     "chalk": "^4.1.0"
   },
   "peerDependencies": {
-    "detox": "^19.6.9"
+    "detox": "^19.7.1"
   },
   "builders": "./executors.json",
   "ng-update": {

packages/detox/src/utils/versions.ts

@@ -1,4 +1,4 @@
 export const nxVersion = require('../../package.json').version;
 
-export const detoxVersion = '19.6.9';
+export const detoxVersion = '19.7.1';
 export const testingLibraryJestDom = '5.16.4';

packages/react-native/migrations.json

@@ -599,6 +599,43 @@
           "alwaysAddToPackageJson": false
         }
       }
+    },
+    "14.2.1": {
+      "version": "14.2.1-beta.0",
+      "packages": {
+        "metro": {
+          "version": "0.71.0",
+          "alwaysAddToPackageJson": false
+        },
+        "metro-resolver": {
+          "version": "0.71.0",
+          "alwaysAddToPackageJson": false
+        },
+        "metro-babel-register": {
+          "version": "0.71.0",
+          "alwaysAddToPackageJson": false
+        },
+        "metro-config": {
+          "version": "0.71.0",
+          "alwaysAddToPackageJson": false
+        },
+        "metro-react-native-babel-preset": {
+          "version": "0.71.0",
+          "alwaysAddToPackageJson": false
+        },
+        "@testing-library/jest-native": {
+          "version": "4.0.5",
+          "alwaysAddToPackageJson": false
+        },
+        "@babel/runtime": {
+          "version": "7.18.3",
+          "alwaysAddToPackageJson": false
+        },
+        "@types/react-native": {
+          "version": "0.67.8",
+          "alwaysAddToPackageJson": false
+        }
+      }
     }
   }
 }

packages/react-native/package.json

@@ -35,7 +35,7 @@
     "enhanced-resolve": "^5.8.3",
     "fs-extra": "^10.1.0",
     "ignore": "^5.0.4",
-    "metro-resolver": "^0.70.3",
+    "metro-resolver": "^0.71.0",
     "node-fetch": "^2.6.7",
     "tsconfig-paths": "^3.9.0"
   },

packages/react-native/plugins/metro-resolver.ts

@@ -17,12 +17,11 @@ export function getResolveRequest(extensions: string[]) {
   return function (
     _context: any,
     realModuleName: string,
-    platform: string | null,
-    moduleName: string
+    platform: string | null
   ) {
     const DEBUG = process.env.NX_REACT_NATIVE_DEBUG === 'true';
 
-    if (DEBUG) console.log(chalk.cyan(`[Nx] Resolving: ${moduleName}`));
+    if (DEBUG) console.log(chalk.cyan(`[Nx] Resolving: ${realModuleName}`));
 
     const { resolveRequest, ...context } = _context;
 
@@ -32,15 +31,14 @@ export function getResolveRequest(extensions: string[]) {
         context,
         extensions,
         realModuleName,
-        moduleName,
         platform,
         DEBUG
       ) ||
-      pnpmResolver(extensions, context, realModuleName, moduleName, DEBUG);
+      pnpmResolver(extensions, context, realModuleName, DEBUG);
     if (resolvedPath) {
       return resolvedPath;
     }
-    throw new Error(`Cannot resolve ${chalk.bold(moduleName)}`);
+    throw new Error(`Cannot resolve ${chalk.bold(realModuleName)}`);
   };
 }
 
@@ -75,7 +73,6 @@ function pnpmResolver(
   extensions: string[],
   context: any,
   realModuleName: string,
-  moduleName: string,
   debug: boolean
 ) {
   try {
@@ -93,7 +90,7 @@ function pnpmResolver(
     if (debug)
       console.log(
         chalk.cyan(
-          `[Nx] Unable to resolve with default PNPM resolver: ${moduleName}`
+          `[Nx] Unable to resolve with default PNPM resolver: ${realModuleName}`
         )
       );
   }
@@ -107,7 +104,6 @@ function tsconfigPathsResolver(
   context: any,
   extensions: string[],
   realModuleName: string,
-  moduleName: string,
   platform: string,
   debug: boolean
 ) {
@@ -124,7 +120,7 @@ function tsconfigPathsResolver(
   } else {
     if (debug) {
       console.log(
-        chalk.red(`[Nx] Failed to resolve ${chalk.bold(moduleName)}`)
+        chalk.red(`[Nx] Failed to resolve ${chalk.bold(realModuleName)}`)
       );
       console.log(
         chalk.cyan(

packages/react-native/src/generators/application/application.spec.ts

@@ -22,6 +22,7 @@ describe('app', () => {
       displayName: 'myApp',
       linter: Linter.EsLint,
       e2eTestRunner: 'none',
+      install: false,
     });
     const workspaceJson = readWorkspaceConfiguration(appTree);
     const projects = getProjects(appTree);
@@ -37,6 +38,7 @@ describe('app', () => {
       tags: 'one,two',
       linter: Linter.EsLint,
       e2eTestRunner: 'none',
+      install: false,
     });
 
     const { projects } = readJson(appTree, '/workspace.json');
@@ -53,6 +55,7 @@ describe('app', () => {
       displayName: 'myApp',
       linter: Linter.EsLint,
       e2eTestRunner: 'none',
+      install: false,
     });
     expect(appTree.exists('apps/my-app/src/app/App.tsx')).toBeTruthy();
     expect(appTree.exists('apps/my-app/src/main.tsx')).toBeTruthy();
@@ -71,6 +74,7 @@ describe('app', () => {
       displayName: 'myApp',
       linter: Linter.EsLint,
       e2eTestRunner: 'none',
+      install: false,
     });
 
     const tsconfig = readJson(appTree, 'apps/my-app/tsconfig.json');

packages/react-native/src/generators/application/application.ts

@@ -46,7 +46,10 @@ export async function reactNativeApplicationGenerator(
   );
   const detoxTask = await addDetox(host, options);
   const symlinkTask = runSymlink(host.root, options.appProjectRoot);
-  const podInstallTask = runPodInstall(join(host.root, options.iosProjectRoot));
+  const podInstallTask = runPodInstall(
+    join(host.root, options.iosProjectRoot),
+    options.install
+  );
   const chmodTaskGradlew = runChmod(
     join(host.root, options.androidProjectRoot, 'gradlew'),
     0o775

packages/react-native/src/generators/application/lib/nomalize-options.spec.ts

@@ -8,6 +8,7 @@ describe('Normalize Options', () => {
       name: 'my-app',
       linter: Linter.EsLint,
       e2eTestRunner: 'none',
+      install: false,
     };
     const options = normalizeOptions(schema);
     expect(options).toEqual({
@@ -24,13 +25,15 @@ describe('Normalize Options', () => {
       entryFile: 'src/main.tsx',
       e2eTestRunner: 'none',
       unitTestRunner: 'jest',
+      install: false,
     });
   });
 
   it('should normalize options with name in camel case', () => {
     const schema: Schema = {
       name: 'myApp',
       e2eTestRunner: 'none',
+      install: false,
     };
     const options = normalizeOptions(schema);
     expect(options).toEqual({
@@ -46,6 +49,7 @@ describe('Normalize Options', () => {
       entryFile: 'src/main.tsx',
       e2eTestRunner: 'none',
       unitTestRunner: 'jest',
+      install: false,
     });
   });
 
@@ -54,6 +58,7 @@ describe('Normalize Options', () => {
       name: 'my-app',
       directory: 'directory',
       e2eTestRunner: 'none',
+      install: false,
     };
     const options = normalizeOptions(schema);
     expect(options).toEqual({
@@ -70,13 +75,15 @@ describe('Normalize Options', () => {
       entryFile: 'src/main.tsx',
       e2eTestRunner: 'none',
       unitTestRunner: 'jest',
+      install: false,
     });
   });
 
   it('should normalize options that has directory in its name', () => {
     const schema: Schema = {
       name: 'directory/my-app',
       e2eTestRunner: 'none',
+      install: false,
     };
     const options = normalizeOptions(schema);
     expect(options).toEqual({
@@ -92,6 +99,7 @@ describe('Normalize Options', () => {
       entryFile: 'src/main.tsx',
       e2eTestRunner: 'none',
       unitTestRunner: 'jest',
+      install: false,
     });
   });
 
@@ -100,6 +108,7 @@ describe('Normalize Options', () => {
       name: 'my-app',
       displayName: 'My App',
       e2eTestRunner: 'none',
+      install: false,
     };
     const options = normalizeOptions(schema);
     expect(options).toEqual({
@@ -115,6 +124,7 @@ describe('Normalize Options', () => {
       entryFile: 'src/main.tsx',
       e2eTestRunner: 'none',
       unitTestRunner: 'jest',
+      install: false,
     });
   });
 });

packages/react-native/src/generators/application/schema.d.ts

@@ -14,4 +14,5 @@ export interface Schema {
   linter?: Linter;
   setParserOptionsProject?: boolean;
   e2eTestRunner?: 'detox' | 'none';
+  install: boolean; // default is true
 }

packages/react-native/src/generators/application/schema.json

@@ -71,6 +71,11 @@
       "type": "string",
       "enum": ["detox", "none"],
       "default": "detox"
+    },
+    "install": {
+      "type": "boolean",
+      "description": "Runs `pod install` for native modules before building iOS app.",
+      "default": true
     }
   },
   "required": []

packages/react-native/src/generators/init/init.ts

@@ -11,6 +11,7 @@ import { runTasksInSerial } from '@nrwl/workspace/src/utilities/run-tasks-in-ser
 import { jestInitGenerator } from '@nrwl/jest';
 import { detoxInitGenerator } from '@nrwl/detox';
 import {
+  reactTestRendererVersion,
   reactVersion,
   typesReactVersion,
 } from '@nrwl/react/src/utils/versions';
@@ -28,7 +29,6 @@ import {
   reactNativeSvgTransformerVersion,
   reactNativeSvgVersion,
   reactNativeVersion,
-  reactTestRendererVersion,
   testingLibraryJestNativeVersion,
   testingLibraryReactNativeVersion,
   typesNodeVersion,

packages/react-native/src/generators/stories/stories-app.spec.ts

@@ -61,6 +61,7 @@ export async function createTestUIApp(libName: string): Promise<Tree> {
     style: 'css',
     unitTestRunner: 'none',
     name: libName,
+    install: false,
   });
   return appTree;
 }

packages/react-native/src/generators/stories/stories-lib.spec.ts

@@ -81,6 +81,7 @@ export async function createTestUILib(libName: string): Promise<Tree> {
     skipFormat: false,
     unitTestRunner: 'none',
     name: `${libName}-e2e`,
+    install: false,
   });
   return appTree;
 }

packages/react-native/src/generators/storybook-configuration/configuration.spec.ts

@@ -129,6 +129,7 @@ export async function createTestAppLib(
     unitTestRunner: 'none',
     name: libName,
     js: plainJS,
+    install: false,
   });
 
   await componentGenerator(appTree, {