Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): throw graceful error in runNxMigration() if no collection #10655

Merged
merged 4 commits into from
Jun 10, 2022
Merged

feat(core): throw graceful error in runNxMigration() if no collection #10655

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9671350
feat(core): throw graceful error in runNxMigration() if no collection
trakhimenok Jun 9, 2022
120475f
feat(core): check for !value instead of try/catch
trakhimenok Jun 9, 2022
50d309f
feat(core): check for missing collection
trakhimenok Jun 9, 2022
9765504
feat(core): bette error message
trakhimenok Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/nx/src/command-line/migrate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,6 +1040,12 @@ async function runNxMigration(root: string, packageName: string, name: string) {

const collection = readJsonFile<MigrationsJson>(collectionPath);
const g = collection.generators || collection.schematics;
if (!g[name]) {
const source = collection.generators ? 'generators' : 'schematics';
throw new Error(
`Unable to determine implementation path for "${collectionPath}:${name}" using collection.${source}`
);
}
const implRelativePath = g[name].implementation || g[name].factory;

let implPath: string;
Expand Down