Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): add flag to skip calculate resolve mappings for yarn works… #11239

Closed

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Jul 21, 2022

…paces and the likes

ISSUES CLOSED: #11221

Current Behavior

For workspaces that add libraries by linking in node_modules (yarn workspaces etc...) with specific versions rather than the latest, calculateResolveMappings in nrwl/node:node does not respect this

Expected Behavior

Add a flag skipCalculateMappings for nrwl/node:node executor so users of these types of workspaces can skip this logic

Related Issue(s)

Fixes #11221

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jul 21, 2022 at 0:17AM (UTC)

@nartc nartc marked this pull request as ready for review July 21, 2022 12:12
@nartc nartc enabled auto-merge (squash) July 21, 2022 12:12
@nartc nartc disabled auto-merge July 21, 2022 12:12
@nartc nartc requested a review from AgentEnder July 21, 2022 12:12
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to avoid a flag?

Can we try the real Module._load? If it works, hurray. If it doesn't, then we check the mappings? If it's not in the mappings, we should throw the original error.

const match = keys.find((k) => request === k);

@nartc
Copy link
Contributor Author

nartc commented Jul 23, 2022

@FrozenPandaz I can give that a go

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/node:node calculateResolveMappings doesn't think about version of library
2 participants