-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): add flag to skip calculate resolve mappings for yarn works… #11239
Conversation
…paces and the likes ISSUES CLOSED: nrwl#11221
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to avoid a flag?
Can we try the real Module._load
? If it works, hurray. If it doesn't, then we check the mappings? If it's not in the mappings, we should throw the original error.
const match = keys.find((k) => request === k); |
@FrozenPandaz I can give that a go |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
…paces and the likes
ISSUES CLOSED: #11221
Current Behavior
For workspaces that add libraries by linking in
node_modules
(yarn workspaces etc...) with specific versions rather than the latest,calculateResolveMappings
innrwl/node:node
does not respect thisExpected Behavior
Add a flag
skipCalculateMappings
fornrwl/node:node
executor so users of these types of workspaces can skip this logicRelated Issue(s)
Fixes #11221