New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): properly serialize override with object arg for command line #12499
fix(core): properly serialize override with object arg for command line #12499
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @FrozenPandaz, after a second look at my PR I started questioning what the expected behavior should be. In the previous versions before this problem occurred, arguments passed with dot notation were printed in the same way in terminal. Running
would have printed
Could you confirm that this would be the expected behavior here as well? Then I could rework the PR. |
f27bc07
to
a3f7e0c
Compare
Avoid outputting object args as [object Object]. Is related to nrwl#10808
This reverts commit c16b33a.
…mmand line" This reverts commit 83f9c3c.
a3f7e0c
to
45c9ad5
Compare
45c9ad5
to
74bbe77
Compare
Sorry, it's been a while. Thank you so much for your work here! The fix was in the right place but I found some code that we can reuse. This logic isn't the cleanest... I think this logic should be kind of unnecessary. Rather than unparsing the parsed arguments which were actually passed, there should be a way where we can directly keep the arguments which were actually passed. We will look into in the near future. For now, I fixed it a simpler way without exposing the underlying parsing of a single option. We actually have this code elsewhere so I moved it from there. I saw you actually had some logic which used the underlying parsing of a single option but I'm hoping we will fix it in a better strategy soon. Let's go with this fix for now, so that your issue is resolved while we work on a better strategy for this. Again, thank you so much for your work. I can take it from here 👍 |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Avoid printing object args as [object Object] in terminal.
Current Behavior
When we pass not nx arguments as object
the task runner will print
[object Object]
instead of the passed argumentsExpected Behavior
It should print unparsed arguments
Related Issue(s)
Fixes #10808