Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): only generate shallow dependencies when building with tsc and swc #12857

Merged
merged 1 commit into from Oct 27, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Oct 27, 2022

This PR fixes an issue where peerDependencies of the generated package.json contains a huge list of nested deps.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 27, 2022 at 7:47PM (UTC)

@jaysoo jaysoo changed the title fix(js): only generate shallow dependencies when building with tsc an… fix(js): only generate shallow dependencies when building with tsc and swc Oct 27, 2022
@jaysoo jaysoo force-pushed the fix/js-shallow-deps-in-package-json branch from 48915ba to 66e1bc5 Compare October 27, 2022 19:46
@jaysoo jaysoo enabled auto-merge (squash) October 27, 2022 19:51
@jaysoo jaysoo merged commit 5f584ea into nrwl:master Oct 27, 2022
jaysoo added a commit that referenced this pull request Oct 28, 2022
@JosefBredereck
Copy link
Contributor

@jaysoo is there a reason this got reverted?
I think it got changed because of a similar reason we discuss in #10227, and it seems like a legit change.
When I see it correctly, the rollup executor does the same thing.

const { target, dependencies } = calculateProjectDependencies(
context.projectGraph,
context.root,
context.projectName,
context.targetName,
context.configurationName,
true

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants