feat(core): add options to disable loading dotenv files #14016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add task runner option 'loadDotEnvFiles' to the default task runner. When this option is false, no .env file as described in the env file hierarchy of the Nx docs will be loaded. When this option is explicitly set to true or not set at all, then the .env files will be loaded normally. Add option 'loadDotEnvFile' to run-commands. When this option is false, or the task runner's 'loadDotEnvFiles' is explicitly set to false, then the ".env" file in the CWD will not be loaded. When this option is explicitly set its behaviour will override the option 'loadDotEnvFiles' from the task runner. This option will be ignored if the 'envFile' option is present. When this option is explicitly set to true or not set at all, then by default the ".env" file from the CWD will be loaded normally.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Anyone ever have the CircleCI pipeline fail?
|
|
Hi @dschnare Thanks for opening the PR. We want to discuss the changes internally and provide a way forward if needed. I'll close this issue since it's not mergeable as is. Let us know via a new issue or discussion if you want to bring any questions/concerns up. Thanks again! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Loading environment variables are loaded by default following this file hierarchy.
Additionally, by default a ".env" file in the current working directly is loaded when using the "nx:run-commands" executor.
Expected Behavior
Default Task Runner
A new option has been added
loadDotEnvFilesthat can be set to disable any .env file from being loaded. If not set, or explicitly setting to true, then the normal .env file loading behavior takes place.nx:run-commands
A new option has been added
loadDotEnvFilethat can be set to disable loading the ".env" file from the current working directory. If not set, then the default loading of the ".env" file is controlled by the task runner option "loadDotEnvFiles". When this option is explicitly set it has precedence over the task runner optionloadDotEnvFiles.If the existing option
envFileis set, then the optionloadDotEnvFilewill be ignored.Fixes #14010