Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure target-only argument is rewritten correctly to be forwarded #17971

Merged
merged 3 commits into from Sep 21, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh commented Jul 5, 2023

Current Behavior

When running with target only and attempting to forward args to commands, you are forced to provide both target and project.

e.g.

nx build -- arg1 -t ./some/path

Results in Cannot find project 'arg1'. This worked as expected prior to #15193

Expected Behavior

When using -- to designate where you want to start passing args

nx build -- arg1 -t ./some/path

Will correctly translate to

nx run build arg1 -t ./some/path

Rather than

nx run arg1:build -t ./some/path

Related Issue(s)

Fixes #16499

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner July 5, 2023 15:55
@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 4:00pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 5, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1b101c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder changed the title fix(nx): ensure target-only argument is rewritten correctly to be forwarded fix(core): ensure target-only argument is rewritten correctly to be forwarded Sep 21, 2023
@AgentEnder AgentEnder merged commit 91b1451 into nrwl:master Sep 21, 2023
14 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
@MarkMcCulloh MarkMcCulloh deleted the nx-forward-more-args branch September 27, 2023 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to forward positional arguments
2 participants