fix(misc): use caret for semver version #18140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1df94d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
This was referenced Jul 17, 2023
This was referenced Sep 3, 2023
AgentEnder
approved these changes
Sep 21, 2023
LukasTy
commented
Sep 22, 2023
|
@AgentEnder I've synched the branch with master and also changed other instances of direct |
mandarini
force-pushed
the
loosen-semver-pkg-modifier
branch
from
1df94d7
to
6ae413f
Compare
mandarini
approved these changes
Jan 30, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a36dce1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
mandarini
force-pushed
the
loosen-semver-pkg-modifier
branch
from
6ae413f
to
e6c9472
Compare
Coly010
approved these changes
Jan 30, 2024
mandarini
force-pushed
the
loosen-semver-pkg-modifier
branch
from
e6c9472
to
5edf072
Compare
mandarini
force-pushed
the
loosen-semver-pkg-modifier
branch
from
5edf072
to
a36dce1
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 2, 2024
(cherry picked from commit 857a07d)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, the
semverpackage has a locked version, whereas most of the other dependencies seem to be prefixed with either caret or a tilde to allow library consumers to update the version they use.Am I missing something, but having this dependency locked to this specific version does not seem to be required for any specific reason?
Expected Behavior
Having such a common package not locked to a specific version would avoid the requirement of having multiple dependencies for even the same major version as can be observed here:
Related PR: #17759