fix(core): ensure output paths returned are unique #18207
Merged
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
AgentEnder
force-pushed
the
fix/caching_issue_with_multiple_outputs
branch
from
abae52e to
2849a54
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f490119. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/caching_issue_with_multiple_outputs
branch
3 times, most recently
from
4ff189a to
b5230bb
Compare
AgentEnder
approved these changes
Jul 19, 2024
AgentEnder
force-pushed
the
fix/caching_issue_with_multiple_outputs
branch
3 times, most recently
from
3f7d9b7 to
3c8245a
Compare
It is possible for users to define multiple duplicate outputs. This is leading to fs related issues like `ENOTEMPTY: directory not empty, rmdir`. The reason this occurs is that the src will tried to be copied to the cached directory in parallel for all output paths and is the reason why these errors are seen sporadically. By ensuring output paths are unique, we only ever copy one path which resolves this issue. fixes nrwl#17277, #nrwl#16337
AgentEnder
force-pushed
the
fix/caching_issue_with_multiple_outputs
branch
from
3c8245a to
f490119
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 24, 2024
It is possible for users to define multiple duplicate outputs in their project.json. This is leading to fs related issues like `ENOTEMPTY: directory not empty, rmdir`. The reason this occurs is that the src will tried to be copied to the cached directory in parallel for all output paths (even duplicated ones) and is the reason why these errors are seen sporadically. By ensuring output paths are unique, we only ever copy one path which resolves this issue. Note: There may still be an issue present if there is a glob that is overlapping another directory i.e: `cdk.out/*` and `cdk.out`, however have not been able to reproduce a fs error while testing. fixes #17277, #16337 ## Current Behavior If you have a project.json which has duplicate output entires, it is possible to receive fs related errors when the cache is being written to disk. ## Expected Behavior each output should only be copied once into the caches directory. ## Related Issue(s) #17277, #16337 Fixes #17277, #16337 (cherry picked from commit 918b8fb)
This was referenced Jul 26, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for users to define multiple duplicate outputs in their project.json. This is leading to fs related issues like
ENOTEMPTY: directory not empty, rmdir. The reason this occurs is that the src will tried to be copied to the cached directory in parallel for all output paths (even duplicated ones) and is the reason why these errors are seen sporadically. By ensuring output paths are unique, we only ever copy one path which resolves this issue.Note: There may still be an issue present if there is a glob that is overlapping another directory i.e:
cdk.out/*andcdk.out, however have not been able to reproduce a fs error while testing.fixes #17277, #16337
Current Behavior
If you have a project.json which has duplicate output entires, it is possible to receive fs related errors when the cache is being written to disk.
Expected Behavior
each output should only be copied once into the caches directory.
Related Issue(s)
#17277, #16337
Fixes #17277, #16337