Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): ensure package detection works in PnP #18394

Merged
merged 2 commits into from
Aug 3, 2023
Merged

fix(linter): ensure package detection works in PnP #18394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba868e0
fix(linter): ensure package detection works in PnP
meeroslav Jul 31, 2023
2fc2a16
feat(linter): use require.resolve to detect version
meeroslav Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/eslint-plugin/src/utils/config-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
import { accessSync } from 'fs';

/**
* Checks if package is available
* @param name name of the package
* @returns
*/
export function packageExists(name: string): boolean {
meeroslav marked this conversation as resolved.
Show resolved Hide resolved
try {
// TODO(meeroslav): This will not work once we start using yarn Berry with PnP
accessSync(`./node_modules/.bin/${name}`);
require.resolve(name);
return true;
} catch (e) {
} catch {
return false;
}
}