Issue 1059: tsJestConfig overriding jest.config.ts global ts-jest config

[jrista]

fix(testing): merge rather than replace ts-jest property on global config
resolves #1059

Please make sure you have read the submission guidelines before posting an PR

Please make sure that your commit message follows our format.

Example: fix(nx): must begin with lowercase

Current Behavior (This is the behavior we have today, before the PR is merged)

Any globals specified in jest.config.js are overridden due to reassignment of the ts-jest property of the globals object. This is a brute force reassignment, rather than a merging of globals defined in jest.config.js and those brought in via angular.json config.

Expected Behavior (This is the new behavior we can expect after the PR is merged)

Globals in jest.config.js will be properly merged with config brought in via angular.json. Critically, this will allow diagnostics to be set to false, which seems to be the primary use case that people are running into issues with.

Issue

1059

[jrista]

I am honestly not sure why the Travis build is failing. The tests run locally, and it even seems as though the tests succeeded in the Travis build that failed, so I'm at a loss...

[twittwer]

At the top it fails at the checkformat script. Can this be the reason, have you run it locally?
https://travis-ci.org/nrwl/nx/jobs/591198574#L532

The command "if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then yarn checkformat --head=$TRAVIS_PULL_REQUEST_SHA --base=$(git merge-base HEAD $TRAVIS_BRANCH); fi" exited with 1.

[jdpearce]

Thanks for this PR, @jrista - it looks like you haven't run yarn format locally. As @twittwer says, it seems to be failing on the Prettier formatting check.

Apart from that, this looks good to me 👍

[jrista]

Yup, sorry guys, didn't run yarn format before. Looks like that fixed it.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.