feat(vue): add private Vue plugin #19009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
FrozenPandaz,
a team,
vsavkin,
AgentEnder and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
commented
Sep 5, 2023
| { | ||
| "name": "@nx/vue", | ||
| "version": "0.0.1", | ||
| "private": true, |
There was a problem hiding this comment.
This will prevent @nx/vue from being published (except to local registry).
jaysoo
force-pushed
the
feat/vite-plugin
branch
2 times, most recently
from
64d6beb
to
33751e7
Compare
mandarini
approved these changes
Sep 5, 2023
AgentEnder
reviewed
Sep 5, 2023
JamesHenry
requested changes
Sep 5, 2023
jaysoo
force-pushed
the
feat/vite-plugin
branch
2 times, most recently
from
db4ec16
to
7086a8c
Compare
JamesHenry
reviewed
Sep 5, 2023
jaysoo
force-pushed
the
feat/vite-plugin
branch
from
7086a8c
to
5610f2a
Compare
meeroslav
reviewed
Sep 5, 2023
meeroslav
reviewed
Sep 5, 2023
7 tasks
JamesHenry
approved these changes
Sep 6, 2023
jaysoo
force-pushed
the
feat/vite-plugin
branch
from
5610f2a
to
5886f3c
Compare
jaysoo
force-pushed
the
feat/vite-plugin
branch
from
5886f3c
to
1643d4e
Compare
AgentEnder
approved these changes
Sep 6, 2023
FrozenPandaz
approved these changes
Sep 6, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an empty vue plugin to start adding generators and executors to. It is marked as
privatefor now so we don't publish until it is feature complete. The usual targets are setup (lint, test, build).Also adds CODEOWNERS entry for Vue. For now it is the JS maintainers since Katerina, Nicholas, and myself are the same people working on Vue. We can change that later if needed.