Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): handle non-JSON eslintrc files when updating overrides #19026

Merged
merged 1 commit into from Sep 6, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 6, 2023

The new ESLint overrides update logic only works if the config is:

  1. .esilntrc.json -- we assume config is JSON when updating old config format
  2. eslint.config.js -- we support new flat config format, but it is different from existing .eslintrc.js format

For other formats like .eslintrc.js, .eslintrc.yaml, etc., we should ignore updating the overrides entry since they are not in the expected format .

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #19020

@jaysoo jaysoo requested a review from a team as a code owner September 6, 2023 14:44
@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 3:37pm

@jaysoo jaysoo self-assigned this Sep 6, 2023
@jaysoo jaysoo added the scope: linter Issues related to Eslint support in Nx label Sep 6, 2023
@jaysoo
Copy link
Member Author

jaysoo commented Sep 6, 2023

One of the Node e2e tested timed out in CI, bumped it from 1 minute to 5 minutes thresshold.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration update-16-8-0-add-ignored-files is failing
4 participants