Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): consider index/folder imports in manual file resolution #19030

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix(bundling): consider index/folder imports in manual file resolution #19030

merged 1 commit into from
Jan 30, 2024

Conversation

JanPretzel
Copy link
Contributor

Current Behavior

nxViteTsPaths manual fallback resolution does not take index/folder imports into account.

Expected Behavior

nxViteTsPaths manual fallback resolution should be able to resolve index/folder imports when importing via a configured TS path with placeholder.

Related Issue(s)

Fixes #19028

@JanPretzel JanPretzel requested a review from a team as a code owner September 6, 2023 15:33
@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 8:28am

@senputra
Copy link

Bump! This is a good fix. I need this.

@christowiz
Copy link

I spent a couple days tracking down this issue as well.

@sgtsquiggs
Copy link

is there anything blocking this fix from being merged?

@mandarini mandarini merged commit 82a0d61 into nrwl:master Jan 30, 2024
14 checks passed
@mandarini
Copy link
Member

thank you for this @JanPretzel

FrozenPandaz pushed a commit that referenced this pull request Jan 31, 2024
@JanPretzel JanPretzel deleted the fix/manual-file-resolution branch January 31, 2024 10:58
Copy link

github-actions bot commented Feb 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual file resolution in vite nx-tsconfig-paths.plugin does not take index/directory imports into account
7 participants