fix(node): explicitly check that project is a library before updating imports

[jaysoo]

This PR fixes an issue where projects that have no type (e.g. application or library) cause the move/convert-to-monorepo generator to fail. You will see an error like this:

>  NX  Generating @nx/workspace:convert-to-monorepo


 >  NX   unable to find "" in tsconfig.base.json compilerOptions.paths


Error: unable to find "" in tsconfig.base.json compilerOptions.paths
    at updateImports (/Users/zackderose/standalone-example/node_modules/@nx/workspace/src/generators/move/lib/update-imports.js:75:23)
    at moveGeneratorInternal (/Users/zackderose/standalone-example/node_modules/@nx/workspace/src/generators/move/move.js:43:40)
    at async moveGenerator (/Users/zackderose/standalone-example/node_modules/@nx/workspace/src/generators/move/move.js:23:5)
    at async monorepoGenerator (/Users/zackderose/standalone-example/node_modules/@nx/workspace/src/generators/convert-to-monorepo/convert-to-monorepo.js:25:9)
    at async /Users/zackderose/standalone-example/node_modules/nx/src/command-line/generate/generate.js:248:26
    at async handleErrors (/Users/zackderose/standalone-example/node_modules/nx/src/utils/params.js:9:16)
    at async Object.handler (/Users/zackderose/standalone-example/node_modules/nx/src/command-line/generate/command-object.js:13:22)

This happens because non-library projects don't have an entry in tsconfig paths, so let's check that projectType === 'library' instead of projectType !== 'application'.

---

Also, update the node app generator to set e2e project as type: 'application', which caused this issue to surface.

Current Behavior

move and convert-to-monorepo generators fail when project type is undefined.

Expected Behavior

move and convert-to-monorepo generators work even if project type is undefined.

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview		Sep 6, 2023 9:24pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 027bdcd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected --target=e2e --base=9ba98f4b25b8cb5263ab4cb45539028471988a03 --head=027bdcd20d41adec434d48a7e57bf5e6cb1d714d --parallel=1
• nx affected --target=test --base=9ba98f4b25b8cb5263ab4cb45539028471988a03 --head=027bdcd20d41adec434d48a7e57bf5e6cb1d714d --parallel=1
• nx affected --target=build --base=9ba98f4b25b8cb5263ab4cb45539028471988a03 --head=027bdcd20d41adec434d48a7e57bf5e6cb1d714d --parallel=3
• nx affected --target=lint --base=9ba98f4b25b8cb5263ab4cb45539028471988a03 --head=027bdcd20d41adec434d48a7e57bf5e6cb1d714d --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=9ba98f4b25b8cb5263ab4cb45539028471988a03 --head=027bdcd20d41adec434d48a7e57bf5e6cb1d714d
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=9ba98f4b25b8cb5263ab4cb45539028471988a03 --head=027bdcd20d41adec434d48a7e57bf5e6cb1d714d

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.