Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): warn users when additionalEntryPoints do not match any files #19107

Merged
merged 1 commit into from Sep 12, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 11, 2023

When files in additionalEntryPoints do not match any files, it is very likely a mistake by the user. The warning will allow them to correct the pattern or remove it if it is unused.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner September 11, 2023 14:12
@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2023 1:45pm

@jaysoo jaysoo force-pushed the feat/warn-unmatched-entry-points branch 3 times, most recently from 133759d to 68168cd Compare September 11, 2023 17:55
@jaysoo jaysoo force-pushed the feat/warn-unmatched-entry-points branch from 68168cd to a0a826a Compare September 12, 2023 13:44
@jaysoo jaysoo merged commit fdbf000 into nrwl:master Sep 12, 2023
15 checks passed
@jaysoo jaysoo deleted the feat/warn-unmatched-entry-points branch September 12, 2023 15:19
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants