Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): detect dependencies in .cjs and .cts files #19127

Merged
merged 2 commits into from Sep 12, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 12, 2023

This PR allows dependencies in.cjs and .cts files to also be detected. It causes issues with @nx/dependency-checks among other things.

Current Behavior

Dependencies from .cjs and .cts files are missing.

Expected Behavior

Dependencies from .cjs and .cts files are picked up.

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner September 12, 2023 15:16
@jaysoo jaysoo requested a review from vsavkin September 12, 2023 15:16
@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2023 4:25pm

@FrozenPandaz FrozenPandaz merged commit 17767cf into nrwl:master Sep 12, 2023
15 checks passed
@jaysoo jaysoo deleted the fix/detect-deps-in-cjs branch September 12, 2023 17:35
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants