feat(devkit): add method for tree-aware glob search #19128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
feat/devkit/glob-helper
branch
from
b859794
to
288c1d9
Compare
AgentEnder
force-pushed
the
feat/devkit/glob-helper
branch
from
288c1d9
to
f2474e9
Compare
FrozenPandaz
requested changes
Sep 12, 2023
| * @param patterns A list of glob patterns | ||
| * @returns Normalized paths in the workspace that match the provided glob patterns. | ||
| */ | ||
| export async function glob(patterns: string[]): Promise<string[]>; |
There was a problem hiding this comment.
I'm uneasy about exposing this version of it. Why use this instead of fast-glob or some minimal wrapper of globset? Anyways, I'd say we shouldn't do this until someone asks for it.
There was a problem hiding this comment.
You'd use this over fast-glob or globset when the intention is to be consistent with how globs run for the rest of Nx, I think its pretty valuable and I'd likely use it for nx-dotnet.
AgentEnder
force-pushed
the
feat/devkit/glob-helper
branch
from
f2474e9
to
66a43f1
Compare
AgentEnder
force-pushed
the
feat/devkit/glob-helper
branch
from
4f0600d
to
6cef621
Compare
AgentEnder
force-pushed
the
feat/devkit/glob-helper
branch
from
8399ab3
to
1cea653
Compare
… point s.t. they do not get included in published code chore(core): move nx/internal-testing-utils -> nx/src/internal-testing-utils
AgentEnder
force-pushed
the
feat/devkit/glob-helper
branch
from
1cea653
to
430ede0
Compare
FrozenPandaz
approved these changes
Sep 13, 2023
|
|
||
| const matches = new Set(globWithWorkspaceContext(root, patterns)); | ||
|
|
||
| if ('root' in treeOrPatterns) { |
There was a problem hiding this comment.
Remove the non-tree version.
AgentEnder
force-pushed
the
feat/devkit/glob-helper
branch
from
430ede0
to
7bf5f48
Compare
jaysoo
approved these changes
Sep 13, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is not an easy way to perform a glob search during a generator, as new files on the Tree will not show up, and files deleted on the Tree will still be visible.
Expected Behavior
There is a method exported from
@nx/devkitto perform glob searches. Allowing it to be passed a Tree or just a list of patterns allows folks to take advantage of the glob search in generators, executors, or random scripts easily. This is important, as the glob search provided will also adhere to the way we do glob searches, and can help plugins become more uniform in how patterns are evaluated.Newly created files on the tree show up if it is provided, and deleted files are hidden.
Related Issue(s)
Fixes #