feat(react): allow setting react preset to production when using custom BABEL_ENV #19148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
reviewed
Sep 13, 2023
packages/react/babel.ts
Outdated
| const reactPresetOptions: Record<string, string | boolean> = { | ||
| runtime: presetOptions.runtime ?? 'automatic', | ||
| development: env !== 'production', | ||
| development: |
There was a problem hiding this comment.
I'd rather keep the option development to match the @babel/preset-react option, so it's clear that it is an override.
So something like:
development: presetOptions.development ?? env !== 'production'
jaysoo
approved these changes
Sep 13, 2023
AgentEnder
force-pushed
the
feat/react/allow-babel-prod-without-env-prod
branch
from
ba298c2
to
581c751
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When setting a custom BABEL_ENV, the @nx/react babel preset will pass
development: trueto the react babel preset. This may not be desirable, if you know that you are running webpack in production mode as it can cause errors.Expected Behavior
You can pass an option to force
development: falseRelated Issue(s)
Fixes #