Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): add "new chat" button to AI page #19150

Merged
merged 1 commit into from Sep 14, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 13, 2023

This PR:

  • Adds a New chat button to the AI page. It will reset the messages to [] so AI will not remember current messages.
  • Adds a Stop generating button so users can stop the response from streaming in the UI.
  • Adds a Regenerate button if users press on Stop generating.
  • Makes the thumbs up/down buttons larger so they are easier to press on mobile.
  • Puts the prompt at the bottom so it's consistent with other chat experiences.
  • Update URL to /ai-chat from /ai in case we want the latter in the future for other AI features.

Edit: Updated to include expanded scope

@jaysoo jaysoo requested a review from a team as a code owner September 13, 2023 18:14
@jaysoo jaysoo requested a review from juristr September 13, 2023 18:14
@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 1:48pm

@FrozenPandaz
Copy link
Collaborator

I think "New Chat" down there might be confusing CTA.

I understand you were trying to convey we are starting a new chat now. But a major side effect is that this current chat gets blown away. Someone clicks "New Chat" not realizing their old chat will go away.

I think the following would be better.

  1. Move the button to the right. User will type something, and have different ways of submitting it.
  2. I think the iconography should be something more "Reset"
  3. The behavior I expect, is for the screen to clear. However, I think people will have already typed something. Let's remember what they typed and keep it in the input.

Can we do that? 👀

@jaysoo
Copy link
Member Author

jaysoo commented Sep 14, 2023

Move the button to the right. User will type something, and have different ways of submitting it.

I think having a different way to submitting (i.e. two submit buttons) is confusing too, the user wouldn't know which is the right button when asking questions.

I'm playing around with showing a button above the prompt only when the response has stopped.

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new UI!

@jaysoo jaysoo merged commit 94f71cd into nrwl:master Sep 14, 2023
15 checks passed
@jaysoo jaysoo deleted the docs/ai-ux-enhancements branch September 14, 2023 18:50
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants