Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-native): add useTransformReactJSX babel config to generators #19170

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Tobbb
Copy link
Contributor

@Tobbb Tobbb commented Sep 14, 2023

Current Behavior

Jest tests require import React from 'react' even though this is not required is the component after react 17

Expected Behavior

you don't have to import React from 'react' in your jest tests. should be more consistent with modern react development

Related Issue(s)

Fixes #

@Tobbb Tobbb requested a review from a team as a code owner September 14, 2023 15:01
@Tobbb Tobbb requested a review from jaysoo September 14, 2023 15:01
@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 5:32pm

@mandarini mandarini self-assigned this Jan 30, 2024
@mandarini
Copy link
Member

after confirming with @xiongemi , I am merging this!

@mandarini mandarini enabled auto-merge (squash) January 30, 2024 17:34
@mandarini mandarini merged commit 2f5bca0 into nrwl:master Jan 30, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jan 31, 2024
Copy link

github-actions bot commented Feb 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants