fix(core): unregister in-process ts transpilers when projectGraph is created #19187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Cammisuli
force-pushed
the
feature/nxc-75-jest-tests-fail-when-daemon-is-off-and-swc-nodecore-is-used
branch
from
78047b3
to
6a8193a
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1868b1a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
AgentEnder
reviewed
Sep 15, 2023
| @@ -84,6 +85,8 @@ export async function retrieveWorkspaceFiles( | |||
| 'get-workspace-files:end' | |||
| ); | |||
|
|
|||
| unregisterPluginTSTranspiler(); | |||
There was a problem hiding this comment.
Would the transpiler not just get re-registered when creating the dependencies? It seems like this should be done at the end of createProjectGraphAsync or similar as well.
xiongemi
approved these changes
Sep 15, 2023
Cammisuli
force-pushed
the
feature/nxc-75-jest-tests-fail-when-daemon-is-off-and-swc-nodecore-is-used
branch
from
6a8193a
to
08f5621
Compare
Cammisuli
changed the title
Cammisuli
force-pushed
the
feature/nxc-75-jest-tests-fail-when-daemon-is-off-and-swc-nodecore-is-used
branch
from
08f5621
to
ab1e2f7
Compare
Cammisuli
force-pushed
the
feature/nxc-75-jest-tests-fail-when-daemon-is-off-and-swc-nodecore-is-used
branch
from
ab1e2f7
to
7289c26
Compare
Cammisuli
force-pushed
the
feature/nxc-75-jest-tests-fail-when-daemon-is-off-and-swc-nodecore-is-used
branch
from
7289c26
to
df0ae47
Compare
…-is-off-and-swc-nodecore-is-used
FrozenPandaz
approved these changes
Sep 22, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running
CI=truewe register ts transpilers in the main nx process. Usually this registration happens in the daemon, and has no effect on other processes that get spawned from the main nx process. But when registered in the main process, all child processes get the same registered transpiler.This causes issues with
NX_BATCH_MODE=truewith jest for Nx Plugin tests because jest tried to load jest configuration files (which are in .ts), and when reading these files swc will transpile these to a format that is not supported in jest.Expected Behavior
When we're done reading the workspace files, unregister transpilers so that child processes do not have their
requirefunctions patched.Related Issue(s)
Fixes #