Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): remove emojis from heading ID #19194

Merged
merged 1 commit into from Sep 15, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 15, 2023

Having emojis in the deep-link URIs can be problematic when processing the page. For example, when generating embeddings for AI Chat https://nx.dev/concepts/dte#%F0%9F%8E%89-pro:-build-artifacts becomes https://nx.dev/concepts/dte#-pro-build-artifacts.

Better to leave off non-ASCII characters. Side-effect of this PR is that any previous deep-link that contains emojis will no longer work, but it's a small use-case and users are on the right page still (just not deep-linked to specific section).

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner September 15, 2023 15:51
@jaysoo jaysoo requested a review from juristr September 15, 2023 15:51
@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 5:34pm

@jaysoo jaysoo force-pushed the nx-dev/no-emojis-in-heading-id branch from b44a28b to 62aa63f Compare September 15, 2023 17:26
@jaysoo jaysoo merged commit 9460b86 into nrwl:master Sep 15, 2023
15 checks passed
@jaysoo jaysoo deleted the nx-dev/no-emojis-in-heading-id branch September 15, 2023 17:40
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants