Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): set module: true for swcMinify #19213

Merged
merged 1 commit into from Sep 18, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 18, 2023

Since module is defaulted to false starting in @swc/core@1.3.85, we need to explicitly set it to true when minifying with SWC.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 1:59pm

@jaysoo jaysoo marked this pull request as ready for review September 18, 2023 13:58
@jaysoo jaysoo requested a review from a team as a code owner September 18, 2023 13:58
@ndcunningham ndcunningham merged commit 56481d6 into nrwl:master Sep 18, 2023
15 checks passed
@jaysoo jaysoo deleted the fix/swc-minify-module branch September 18, 2023 15:55
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants