feat(core): include non-project files on fileMap and filesToProcess #19217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8480d22. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/include-non-project-files-on-filemap
branch
2 times, most recently
from
3c24412
to
ebc36dd
Compare
FrozenPandaz
requested changes
Sep 18, 2023
AgentEnder
force-pushed
the
feat/include-non-project-files-on-filemap
branch
from
ebc36dd
to
1149eb0
Compare
AgentEnder
force-pushed
the
feat/include-non-project-files-on-filemap
branch
from
1149eb0
to
ce101d3
Compare
AgentEnder
force-pushed
the
feat/include-non-project-files-on-filemap
branch
from
ce101d3
to
e60defb
Compare
AgentEnder
force-pushed
the
feat/include-non-project-files-on-filemap
branch
from
e60defb
to
3d2cb30
Compare
AgentEnder
force-pushed
the
feat/include-non-project-files-on-filemap
branch
from
3d2cb30
to
a51bac9
Compare
FrozenPandaz
approved these changes
Sep 19, 2023
Comment on lines
23
to
27
| pub struct FileMap { | ||
| pub project_file_map: HashMap<String, Vec<FileData>>, | ||
| pub non_project_files: Vec<FileData> | ||
| } | ||
|
|
| ); | ||
| const isProjectFileData = !!fileData; | ||
| fileData ??= getNonProjectFileData(sourceFile, this.allWorkspaceFiles); |
There was a problem hiding this comment.
Suggested change
| fileData ??= getNonProjectFileData(sourceFile, this.allWorkspaceFiles); | |
| fileData ??= getNonProjectFileData(sourceFile, this.nonProjectFiles); |
FrozenPandaz
requested changes
Sep 19, 2023
AgentEnder
force-pushed
the
feat/include-non-project-files-on-filemap
branch
2 times, most recently
from
b1ca553
to
0055f13
Compare
AgentEnder
force-pushed
the
feat/include-non-project-files-on-filemap
branch
from
0055f13
to
8480d22
Compare
FrozenPandaz
approved these changes
Sep 19, 2023
ndcunningham
approved these changes
Sep 19, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
filesToProcessdoesn't include non project files, so there is no indication inside ofcreateDependenciesif one has changed. This leads to requiring custom caching and hashing behavior on the plugin side to avoid extra work.Expected Behavior
filesToProcessincludes non project filesRelated Issue(s)
Fixes #