feat(repo): remove projectNameAndRoot nx.json option #19218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8ef6472. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
default-as-provided
branch
2 times, most recently
from
0aad937
to
58c1656
Compare
FrozenPandaz
force-pushed
the
default-as-provided
branch
2 times, most recently
from
fc51535
to
9b6727d
Compare
FrozenPandaz
force-pushed
the
default-as-provided
branch
from
9b6727d
to
90e6270
Compare
FrozenPandaz
force-pushed
the
default-as-provided
branch
from
90e6270
to
8147b68
Compare
FrozenPandaz
requested review from
meeroslav,
vsavkin,
mandarini and
a team
as code owners
leosvelperez
requested changes
Sep 20, 2023
Comment on lines
170
to
171
| const example = getExample(callingGenerator, formats); | ||
| logger.warn(deprecationWarning + '\n' + example); |
There was a problem hiding this comment.
This should only be shown when result === 'derived', isn't it?
Comment on lines
15
to
17
| delete nxJson?.workspaceLayout?.projectNameAndRootFormat; | ||
|
|
||
| if (Object.keys(nxJson?.workspaceLayout).length === 0) { |
There was a problem hiding this comment.
nit: we already checked nxJson.workspaceLayout is defined in line 11.
Suggested change
| delete nxJson?.workspaceLayout?.projectNameAndRootFormat; | |
| if (Object.keys(nxJson?.workspaceLayout).length === 0) { | |
| delete nxJson.workspaceLayout.projectNameAndRootFormat; | |
| if (Object.keys(nxJson.workspaceLayout).length === 0) { |
AgentEnder
approved these changes
Sep 20, 2023
FrozenPandaz
force-pushed
the
default-as-provided
branch
2 times, most recently
from
003aeab
to
faa98bf
Compare
FrozenPandaz
force-pushed
the
default-as-provided
branch
from
faa98bf
to
b3c507a
Compare
FrozenPandaz
force-pushed
the
default-as-provided
branch
from
b3c507a
to
8ef6472
Compare
leosvelperez
approved these changes
Sep 21, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When creating a new workspace, the behavior when generating projects changed to the new
as-providedproject name and root format.There's a configuration option which disables the prompt.
Expected Behavior
When creating a new workspace, there are prompts just like for existing workspaces for the name and root of new projects.
There is no configuration to disable the prompt.
Related Issue(s)
Fixes #