Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(react): switch default to typescript configuration for module federation (#19031)" #19345

Closed
wants to merge 2 commits into from

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 26, 2023

This reverts commit 11fcb8f.

Current Behavior

Typescript configuration is throwing an error with --devRemotes

Expected Behavior

Revert the commit until we have fully investigated this issue

Related Issue(s)

Fixes #

@Coly010 Coly010 self-assigned this Sep 26, 2023
@Coly010 Coly010 requested a review from jaysoo September 26, 2023 22:06
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 11:24pm

@Coly010
Copy link
Contributor Author

Coly010 commented Sep 29, 2023

Closed in favour of: #19387

@Coly010 Coly010 closed this Sep 29, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant