Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): update generated file setup for apps #19428

Merged
merged 1 commit into from Oct 4, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Oct 3, 2023

Update our file setup to be consistent with React and Angular setup.

  • No __tests__ folder
  • App and welcome components are under src/app
  • No additional styles for generated components (currently there is a "color: pink" on it)

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner October 3, 2023 16:51
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 7:28pm

@mandarini mandarini merged commit 601b74d into nrwl:master Oct 4, 2023
6 checks passed
@jaysoo jaysoo deleted the feat/vue-generated-files branch October 4, 2023 12:09
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants