fix(vite): prevent vite:build copying package.json when generatePackageJson false

[vneogi199]

closed #19758

Current Behavior

When generatePackageJson is set to false, vite:build copies package.json to output directory.

Expected Behavior

No package.json is generated in the dist folder

Related Issue(s)

Fixes #19758

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Jan 30, 2024 11:01am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3f9208e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected --target=e2e --base=40515c2a0ee0eaa08313b6d19a401a6bb0855320 --head=3f9208eb5941762b17dd2d877d5fe56f8a2c8aac --parallel=1

✅ Successfully ran 5 targets

• nx affected --targets=lint,test,build --base=40515c2a0ee0eaa08313b6d19a401a6bb0855320 --head=3f9208eb5941762b17dd2d877d5fe56f8a2c8aac --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=40515c2a0ee0eaa08313b6d19a401a6bb0855320 --head=3f9208eb5941762b17dd2d877d5fe56f8a2c8aac
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=40515c2a0ee0eaa08313b6d19a401a6bb0855320 --head=3f9208eb5941762b17dd2d877d5fe56f8a2c8aac

---

Sent with 💌 from NxCloud.

[vergilfromadyen]

Hey @vneogi199 (and @jaysoo I suppose), are there any more changes here or can we expect this to land in the codebase soonish?

Thanks and happy holidays :)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bba631f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=2cb241a69f4b20754648cd5f9bd76492b2b2e2c2 --head=bba631f5b165ed751b07115a873e7a4986cdbd68 --parallel=1
• nx affected --targets=lint,test,build --base=2cb241a69f4b20754648cd5f9bd76492b2b2e2c2 --head=bba631f5b165ed751b07115a873e7a4986cdbd68 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=2cb241a69f4b20754648cd5f9bd76492b2b2e2c2 --head=bba631f5b165ed751b07115a873e7a4986cdbd68
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=2cb241a69f4b20754648cd5f9bd76492b2b2e2c2 --head=bba631f5b165ed751b07115a873e7a4986cdbd68

---

Sent with 💌 from NxCloud.

[mandarini]

thanks, makes sense to me

[mandarini]

Thanks for this PR @vneogi199 ! Keep in mind that very very soon we will be moving away from executors, so this change will not have much effect!

[jsmecham]

Keep in mind that very very soon we will be moving away from executors, so this change will not have much effect!

Could you elaborate more on what this means?

[mandarini]

@jsmecham we will elaborate soon, next week, that is! :) It's a new feature!

I'm merging your PR, though, in any case, so you will be able to move forward with your issue!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.