feat(vite): allow passing path to custom tsconfig file when skipTypeCheck is false #19784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6d4463f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Jan 29, 2024
…heck is false When skipTypeCheck is false and no tsconfig file exists in projectRoot, it returns undefined which causes `join(opts.workspaceRoot, opts.tsconfig)` to fail with `The "path" argument must be of type string. Received undefined`. Allow user to pass custom tsconfig file location which can be in parent/child directory of projectRoot
AgentEnder
force-pushed
the
vite-build-custom-tsconfig
branch
from
6d4463f
to
70a0ebd
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 70a0ebd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
skipTypeCheckisfalseand no tsconfig file exists in projectRoot, it returns undefined which causesjoin(opts.workspaceRoot, opts.tsconfig)invalidateTypesto fail withThe "path" argument must be of type string. Received undefined.Allow user to pass custom tsconfig file location which can be in parent/child directory of projectRoot
Current Behavior
If tsconfig does not exist is projectRoot it fails with
The "path" argument must be of type string. Received undefinedExpected Behavior
Allow user to pass custom tsconfig file, so that vite build does not fail and type checking works.
Related Issue(s)