-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): nx build --graph file.json should work in subdirectories #19858
fix(core): nx build --graph file.json should work in subdirectories #19858
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 630ce89. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
95f1471
to
2b99ac0
Compare
2b99ac0
to
ce3432c
Compare
ce3432c
to
7a66fff
Compare
7a66fff
to
06a421d
Compare
ab29e0b
to
d7435a4
Compare
d7435a4
to
b9c0f5e
Compare
b9c0f5e
to
ceca59b
Compare
ceca59b
to
d895d18
Compare
d895d18
to
aa843f7
Compare
ea6674f
to
1d7e74b
Compare
1d7e74b
to
f9966de
Compare
f9966de
to
35ca041
Compare
35ca041
to
c2dd3db
Compare
c2dd3db
to
630ce89
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7d50aa2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
630ce89
to
7d50aa2
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
We rewrite argv to support "infix" target notation (
e.g. nx build my-app
).Expected Behavior
We don't rewrite infix notation before it reaches yargs, as yargs handles parsing things in a more thorough manner. This eliminates some messy areas in our codebase, but also makes sure that flags passed into commands are interpreted correctly in the presence of positionals. Specifically, this fixes the following cases:
nx build --graph stdout
runs the build script for the project that you are inside of instead of looking for a project namedstdout
nx build --graph stdout mypkg
would be odd to run, but would run the build script for mypkgnx run-many -t test,build
runs test + buildnx run-many -t test build
runs test + buildRelated Issue(s)
Fixes #