Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): use default coverageProvider in @nx/vue:library generator when adding vitest #19871

Closed
wants to merge 2 commits into from

Conversation

benkroeger
Copy link
Contributor

Current Behavior

When generating a library with @nx/vue, invokes the vitestGenerator with coverageProvider: 'c8'.
c8 has been deprecated. The new default is v8 (which is already used in @nx/vite:vitest)

Expected Behavior

c8 shouldn't be used as coverageProvider. Instead use the default from @nx/vite:vitest

Related Issue(s)

n.a.

@benkroeger benkroeger requested a review from a team as a code owner October 26, 2023 12:11
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 3:39pm

@mandarini
Copy link
Member

Hey sorry I've been having my eye on this for some time, and I made this PR instead because there were more things to be addressed: #20156

thank you so much for contributing in any case!

@mandarini mandarini closed this Nov 9, 2023
@mandarini mandarini self-assigned this Nov 9, 2023
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants