Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): do not add @vue/tsconfig dependency #19873

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix(vue): do not add @vue/tsconfig dependency #19873

merged 1 commit into from
Jan 30, 2024

Conversation

benkroeger
Copy link
Contributor

Current Behavior

@nx/vue:init generator adds a dev dependency for @vue/tsconfig but this package is never used.

Expected Behavior

do not install @vue/tsconfig when it's not used

Related Issue(s)

n.a.

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 5:31pm

@benkroeger benkroeger marked this pull request as ready for review October 26, 2023 12:46
@benkroeger benkroeger requested a review from a team as a code owner October 26, 2023 12:46
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for contributing!

However, you need to do some additional updates.
references

  • packages/vue/src/generators/init

You need to update test snapshots for init.spec and library.spec

Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
@mandarini mandarini enabled auto-merge (squash) January 29, 2024 17:34
@mandarini mandarini self-assigned this Jan 29, 2024
@mandarini mandarini requested review from jaysoo and ndcunningham and removed request for ndcunningham January 30, 2024 16:36
@mandarini mandarini merged commit cd2d949 into nrwl:master Jan 30, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Benjamin Kroeger <benjamin.kroeger@gmail.com>
(cherry picked from commit cd2d949)
Copy link

github-actions bot commented Feb 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants