New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): track project changes in source map when applying plugins #19955
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e68fb24. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
7bc3d4e
to
d5a1ef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 🎉, I like where this is heading. Few changes, 2 are small syntax nitpicks, 1 is a bit more effort but I think will improve the cohesiveness of the file.
packages/nx/src/project-graph/utils/project-configuration-utils.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/project-graph/utils/project-configuration-utils.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/project-graph/utils/project-configuration-utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 🎉, I like where this is heading. Few changes, 2 are small syntax nitpicks, 1 is a bit more effort but I think will improve the cohesiveness of the file.
5c6e6f7
to
a942023
Compare
3d8a31b
to
91af0b0
Compare
91af0b0
to
cc4dd4f
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
No description provided.