Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): track project changes in source map when applying plugins #19955

Merged
merged 3 commits into from Nov 16, 2023

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Oct 31, 2023

No description provided.

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 4:53pm

@MaxKless MaxKless force-pushed the pcv3-source-maps branch 2 times, most recently from 7bc3d4e to d5a1ef0 Compare November 7, 2023 19:19
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉, I like where this is heading. Few changes, 2 are small syntax nitpicks, 1 is a bit more effort but I think will improve the cohesiveness of the file.

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉, I like where this is heading. Few changes, 2 are small syntax nitpicks, 1 is a bit more effort but I think will improve the cohesiveness of the file.

@MaxKless MaxKless marked this pull request as ready for review November 9, 2023 14:57
@MaxKless MaxKless requested review from a team as code owners November 9, 2023 14:57
@MaxKless MaxKless force-pushed the pcv3-source-maps branch 2 times, most recently from 3d8a31b to 91af0b0 Compare November 10, 2023 12:34
@AgentEnder AgentEnder enabled auto-merge (squash) November 16, 2023 23:43
@AgentEnder AgentEnder merged commit 13f33ea into master Nov 16, 2023
6 checks passed
@AgentEnder AgentEnder deleted the pcv3-source-maps branch November 17, 2023 00:00
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants